Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect to gemini aich #2081

Closed
wants to merge 9 commits into from
Closed

connect to gemini aich #2081

wants to merge 9 commits into from

Conversation

TinyMurky
Copy link
Contributor

DEVELOP

  • Description: 串接AICH gemini 的api

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@TinyMurky TinyMurky requested a review from Luphia August 15, 2024 09:54
@TinyMurky TinyMurky self-assigned this Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 7:01am

@@ -58,7 +58,7 @@ describe('fetchOCRResult', () => {
const result = await module.fetchOCRResult(resultId);

expect(global.fetch).toHaveBeenCalledWith(
expect.stringContaining(`/api/v1/ocr/${resultId}/result`)
expect.stringContaining(`/api/v1/gemini/${resultId}/result`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • api naming issue

@@ -123,7 +123,7 @@ describe('POST OCR', () => {
expect(promiseJson).toBeInstanceOf(Promise);

expect(global.fetch).toHaveBeenCalledWith(
expect.stringContaining('/ocr/upload'),
expect.stringContaining('/gemini/upload'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • api naming issue

@@ -227,7 +227,7 @@ describe('POST OCR', () => {
expect(resultJson).toEqual(resultJsonArrayExpect);

expect(global.fetch).toHaveBeenCalledWith(
expect.stringContaining('/ocr/upload'),
expect.stringContaining('/gemini/upload'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • api naming issue

@Luphia Luphia mentioned this pull request Aug 16, 2024
11 tasks
@TinyMurky
Copy link
Contributor Author

use #2084 instead

@TinyMurky TinyMurky closed this Aug 19, 2024
@Luphia Luphia deleted the feature/ocrSaving branch August 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants